Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support kubernetes 1.22 #258

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Support kubernetes 1.22 #258

merged 3 commits into from
Sep 1, 2022

Conversation

danielmmetz
Copy link
Contributor

@danielmmetz danielmmetz commented Aug 31, 2022 •
edited
Loading

Namely fix the following:

  • replace rbac.authorization.k8s.io/v1beta1 (deprecated in 1.22) with rbac.authorization.k8s.io/v1 (available since 1.8.0)
  • replace apiextensions.k8s.io/v1beta1 (deprecated in 1.22) with apiextensions.k8s.io/v1 (available since 1.16.0)

@danielmmetz danielmmetz changed the title Upgrade away from deprecated APIs Support kubernetes 1.22 Aug 31, 2022
maghamravi
maghamravi previously approved these changes Aug 31, 2022
View reviewed changes
@danielmmetz danielmmetz mentioned this pull request Aug 31, 2022
Merged
danielmmetz
danielmmetz commented Aug 31, 2022
View reviewed changes
deploy/crd.yaml
@@ -12,7 +12,6 @@ spec:
shortNames:
- flinkapp
scope: Namespaced
version: v1beta1
Copy link
Contributor Author

@danielmmetz danielmmetz Aug 31, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per https://kubernetes.io/docs/reference/using-api/deprecation-guide/#customresourcedefinition-v122

danielmmetz added a commit that referenced this pull request Sep 1, 2022
@danielmmetz
Migrate to GitHub Actions for CI (#259)
d588398 
Goal: get the CI integration up and running again.
Progress: Got the unit and lint tests passing. 
Incomplete and putting out of scope: integration test and release functionality. 
  - the integration test stalled at the 20m and eventually timed out. I'm leaving it in, albeit commented out, to make it easier for the next attempter given it does actually run.
  - the release I'm leaving out entirely as I don't intend to make a new release, I just want to make enough progress to have tests execute for #258

Motivation: Upgrade kubenetes artifacts to handle version 1.22.
@danielmmetz danielmmetz merged commit 773b378 into master Sep 1, 2022
@danielmmetz danielmmetz deleted the drop-deprecated-apis branch September 1, 2022 23:10
@jnovick jnovick mentioned this pull request Jan 22, 2023
Closed
sethsaperstein-lyft added a commit that referenced this pull request Mar 30, 2023
@sethsaperstein-lyft
Revert "Support kubernetes 1.22 (#258)"
b0cf15b 
This reverts commit 773b378.
sethsaperstein-lyft added a commit that referenced this pull request Mar 31, 2023
@sethsaperstein-lyft
Revert "Support kubernetes 1.22 (#258)" (#280)
bd15d93 
This reverts commit 773b378.

## overview
Removing this as v1 CRD's breaks integration tests which are using an
old k8s client. Will save this for when we do the 1.22 upgrade in the
near future
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maghamravi maghamravi maghamravi approved these changes

@anandswaminathan anandswaminathan Awaiting requested review from anandswaminathan anandswaminathan is a code owner

@premsantosh premsantosh Awaiting requested review from premsantosh premsantosh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmmetz @maghamravi